Skip to content
This repository was archived by the owner on May 25, 2019. It is now read-only.

Conversation

@sean0x42
Copy link
Owner

This pull request introduces a new permission based system. Players are sorted into one of the following groups.

  • Player: No admin privileges.
  • Tournament Director: Limited admin privileges, such as recording games.
  • Admin: All admin privileges.
  • Developer: Limited admin privileges, but access to developer only tools like the sidekiq monitor.

This PR resolves #155

@sean0x42 sean0x42 added admin panel Features found in the admin panel. player Logging in and signing up, as well as player profiles. 1.3 Proposed feature for 1.3.0 permissions labels Dec 16, 2018
@sean0x42 sean0x42 added this to the Update 1.3.0 milestone Dec 16, 2018
@coveralls
Copy link

coveralls commented Dec 16, 2018

Pull Request Test Coverage Report for Build 377

  • 4 of 173 (2.31%) changed or added relevant lines in 17 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-73.3%) to 16.116%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/models/player.rb 2 3 66.67%
app/controllers/application_controller.rb 0 4 0.0%
app/helpers/application_helper.rb 0 4 0.0%
app/controllers/admin/events_controller.rb 0 5 0.0%
app/controllers/admin/games_controller.rb 0 5 0.0%
app/controllers/admin/players_controller.rb 0 5 0.0%
app/controllers/admin/venues_controller.rb 0 5 0.0%
app/controllers/admin/regions_controller.rb 0 6 0.0%
app/policies/comment_policy.rb 0 11 0.0%
app/policies/event_policy.rb 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
app/models/player.rb 1 72.83%
Totals Coverage Status
Change from base Build 355: -73.3%
Covered Lines: 273
Relevant Lines: 1694

💛 - Coveralls

@sean0x42 sean0x42 self-assigned this Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.3 Proposed feature for 1.3.0 admin panel Features found in the admin panel. permissions player Logging in and signing up, as well as player profiles.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants