-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Serialize objects #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
950d7f2
docs: Update example in README
razor-x b18dc7d
docs: Add Date and Temporal to examples
razor-x fc4fb63
Add float to examples
razor-x ca89e53
Remove test.only
razor-x fad04f2
feat: Serialize plain objects to dot path notation
razor-x e6314d4
doc: Note serialization guarantee
razor-x a671657
Run npm update
razor-x 2661288
Update README.md
razor-x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider using PHP style here? That is:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I did not directly consider it, but thanks for the suggestion.
I chose dot notation because it's the simplest to read, write and parse (and does not need escaping in other contexts like the command line).
The suggested bracket notation would work, but it looks too similar to the competing array notation
bar[]=
. SinceURLSearchParams
standardizes onfoo=a&foo=b
and not bracket notation, I decided not to introduce brackets.Note that we still need to write a standardized parser, and the parser can be more permissive with what it accepts. E.g., the serialize will set the base standard, but our parser can still choose to accept other formats within reason, and if they do not conflict with the serializer.
For example, we can unambiguously parse
foo.bar=1
andfoo[bar]=1
to{ foo: { bar: 1 } }
since the Seam API will not allow brackets or dots in param names.