Change code-style #100
Draft
Change code-style #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And const_iterator rather than iterator
ResetInputBuffer
UpdateBuffers
RewindBuffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just putting this out here in case it's something you might consider merging @sdatkinson. Although i expect it would be a rather controversial change.
I find the code style in this repo unusual in particular w.r.t to the use of
_underscores(which seem to be used inconsistently for various things). I also don't like thethis->pointers for member access. It makes it painful to try and debug issues such as #49 . On this PR I have methodically gone through manually renaming things using camel case and mMember style, removing all the underscores and this-> occurrences. Free functions/Methods have a capital letter at the beginning. I probably missed some stuff. The 130 or so commits are rather sloppily named because it got super tedious but i tried to be careful and to give an indication of the one thing that I was changing in each commit. In some cases member variables that have very short names (e.g. in LSTMCell still have _ prefixes) since it looks ok there.let me know if you think it is something you'd consider! I can clean it up a bit if there is some aspect you don't like or if you don't want to do this (I understand) and I'll just maintain a fork and try and keep it synced with your upstream changes.