ccmlib/scylla_node.py: Enable RF-rack-valid keyspaces by default #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all dtests have been adjusted to work with the configuration option `rf_rack_valid_keyspaces` enabled, let's turn on the option by default. Refs scylladb/scylladb#23071 Refs scylladb/scylla-dtest#5633
|
I tested the changed on Jenkins running Weirdly, the tests took very little time, but maybe it's not that weird. Please take a look at it when reviewing the patch. |
|
Could we do it on dtest level instead? I do not see a reason for forcing it in CCM |
|
Right. I clearly haven't fully woken up yet. :-) I'll close this PR for now. Thanks for the fast feedback! |
One more reason not todo it in CCM There are other users of it in driver tests, which aren't ready for doing this as default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all dtests have been adjusted to work with the configuration option
rf_rack_valid_keyspacesenabled, let's turn on the option by default.Refs scylladb/scylladb#23071
Refs scylladb/scylla-dtest#5633