fix(manager): increase HTTP server waiting timeout #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With more nodes in cluster, it may take longer for the manager to start. The check for 6+ nodes was not enough, there are tests with 5 nodes where the server may fail to start in 3 minutes. Extend the timeout to 5 minutes should cover most cases of slow start and only leave actual issue to throw an exception here.
|
I hope you've also filed a bug on manager, being slow to start! |
it's already analyzed and figured out in: manager dtests are using the scylla under test also for the the manager itself the actual solution would be refactor the tests to use separate scylla 1 node cluster for manager, but I don't see anyone that would follow that anytime soon... |
|
@cezarmoise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With more nodes in cluster, it may take longer for the manager to start.
The check for 6+ nodes was not enough, there are tests with 5 nodes where the server may fail to start in 3 minutes.
Extend the timeout to 5 minutes should cover most cases of slow start and only leave actual issue to throw an exception here.
Example failure with 5 nodes: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/cezar/job/dtest-byo/70/testReport/manager_restore_tests/TestScyllaMgmtRestore/FullDtest___full_split001___test_restore_different_size_cluster_rclone_5_3_/
Example failure with 4 nodes: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/cezar/job/dtest-byo/75/testReport/manager_backup_tests/TestScyllaMgmtBackup/FullDtest___full_split001___test_shutting_down_node_during_backup_native_/