Skip to content

Conversation

@Deexie
Copy link
Contributor

@Deexie Deexie commented May 26, 2025

Currently, ScyllaCluster::repair accesses the first of nodes in a cluster
by calling nodes[0]. However nodes is a dict, keys of which aren't number.

Replace nodes with nodelist() that returns the list of nodes.

@Deexie Deexie requested a review from fruch May 26, 2025 14:15
@fruch
Copy link
Contributor

fruch commented May 26, 2025

@Deexie
can you add something to the description to explain, where its coming from ? how it working or didn't work so far...

Currently, ScyllaCluster::repair accesses the first of nodes in a cluster
by calling nodes[0]. However nodes is a dict, keys of which aren't number.

Replace nodes with nodelist() that returns the list of nodes.
@Deexie
Copy link
Contributor Author

Deexie commented May 28, 2025

_ No description provided. _

@Deexie can you add something to the description to explain, where its coming from ? how it working or didn't work so far...

Done @fruch

@fruch fruch merged commit 24ef70a into scylladb:master May 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants