Skip to content

Conversation

@gleb-cloudius
Copy link

@gleb-cloudius gleb-cloudius commented Mar 24, 2025

Moving ScyllaDB to host ids changes some output to use ids instead of ips. Prepare for that by checking for both.

Testing

Gleb Natapov added 2 commits March 24, 2025 10:11
Current host_id(0 implementation works only if a node is UP since it
contacts the node itself. Change it so that the id is looked up in the
logs and only if this fails we try to contact the node. This way we can
check host id even for a node that is down.
We are changing ScyllaDB to use ids internally, so some logs are
changing to use ids instead of ips. Prepare for that.
@gleb-cloudius gleb-cloudius requested a review from bhalevy March 24, 2025 08:20
@fruch
Copy link
Contributor

fruch commented Mar 24, 2025

@gleb-cloudius FYI after this would be review/merged, the sub-module in dtest would need to be updated.

also I've trigger all of the gating tests with it, to validate it's not breaking anything.

@gleb-cloudius
Copy link
Author

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Contributor

fruch commented Mar 25, 2025

Restarted the first one: https://jenkins.scylladb.com/job/scylla-staging/job/dtest-pytest-gating/897/

It's was a test known to be unstable, and the rerun passed

@fruch fruch merged commit 306843b into scylladb:master Mar 25, 2025
4 checks passed
@fruch
Copy link
Contributor

fruch commented Mar 25, 2025

@gleb-cloudius FYI after this would be review/merged, the sub-module in dtest would need to be updated.

also I've trigger all of the gating tests with it, to validate it's not breaking anything.

Now we can do the dtest part

@mykaul
Copy link
Contributor

mykaul commented Apr 28, 2025

This needs to be backported to 2025.1, as it seems to be failing on it as well, I suspect.

@fruch
Copy link
Contributor

fruch commented Apr 28, 2025

This needs to be backported to 2025.1, as it seems to be failing on it as well, I suspect.

the dtest PR can be backported, once someone would open it up

@fruch
Copy link
Contributor

fruch commented Apr 28, 2025

This needs to be backported to 2025.1, as it seems to be failing on it as well, I suspect.

the dtest PR can be backported, once someone would open it up

https://github.com/scylladb/scylla-dtest/pull/5699, marked it for backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants