-
Notifications
You must be signed in to change notification settings - Fork 72
Fix multi DC token calculation #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi DC token calculation #643
Conversation
Provision multi DC cluster and list `initial_token`: ``` rm -rf ~/.ccm/test ccm create test -i 127.0.0. -n 4:0 -v release:6.2 --scylla cat ~/.ccm/test/*/node.conf | grep init initial_token: -9223372036854775808 initial_token: -9223372036854775708 ``` As you can see only two nodes got `initial_token` To fix that we need to pass `node_locations` to `balanced_tokens_across_dcs` And have ti fixed a bit.
EDIT: there a few test that do use it: https://github.com/search?q=repo%3Ascylladb%2Fscylla-dtest%20initial_token&type=code |
|
@fruch , isreal, can you please approve the pipeline |
Running: https://jenkins.scylladb.com/view/staging/job/scylla-staging/job/dkropachev/job/dtest-gating/2 |
|
@fruch , Two runs failed at the same test: It is known problem, we can consider it passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Provision multi DC cluster and list
initial_token:As you can see only two nodes got
initial_tokenTo fix that we need to pass
node_locationstobalanced_tokens_across_dcsAnd have ti fixed a bit.After the fix:
Fixes: #642