tests/ccmcluster.py: make parse_cluster_status ignore lines that does not match

[dkropachev]

It could fail with following error:

    def parse_cluster_status(self, stdout):
        """
            Output:

            Cluster: 'CCMCluster-reloc'
            ---------------------------
            node1: UP

            return:
            [(node1, UP)]
        """
        nodes_status = []
        for line in stdout.split("\n")[2:]:
>           node, status = line.split(":")
E           ValueError: not enough values to unpack (expected 2, got 1)

[dkropachev]

@fruch , @tchaikov , one more please.

[tchaikov]

could improve the title a little bit:

tests/ccmcluster.py: ignore empty lines in parse_cluster_status()

EDIT: s/ccmlib/tests/.

[tchaikov]

presumably it was an empty line which broke the test. an alternative is:

if not line:
    # ignore empty lines
    continue
node, status = line.split(":", 1)

[dkropachev]

presumably it was an empty line which broke the test. an alternative is:

tbh, I have no idea which line broke it, but it is better to make it as resiliant as possible.

if not line:
    # ignore empty lines
    continue
node, status = line.split(":", 1)

This code will still fail if line does not contain ':'.

[tchaikov]

yes, by looking at the error message, i think the offending line was empty.

as resiliant as possible.

i disagree. we program with a contract. "as resilient as possible" without a contract is error-prune, because we don't have a standard or contract for "as resilient as possible".

anyway, this is not that important in this context.

[tchaikov]

just two nits. lgtm.

[fruch]

LGTM

[fruch]

could improve the title a little bit:

ccmlib/ccmcluster.py: ignore empty lines in parse_cluster_status()

also it's tests/ccmcluster.py, which is kind of important context

[dkropachev]

could improve the title a little bit:

ccmlib/ccmcluster.py: ignore empty lines in parse_cluster_status()

also it's tests/ccmcluster.py, which is kind of important context

Updated.