Fix missing co-fixed-read and co-fixed-write tags in mixed mode HDR histograms #215
+62
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Fixed
The mixed mode was missing "co-fixed-read" and "co-fixed-write" tags in HDR histogram output because the
DoMixed
function wasn't callingRecordReadCoFixedLatency
andRecordWriteCoFixedLatency
methods.Solution
Modified
DoMixed
function inmodes.go
to calculate and record coordinated omission fixed latency for both read and write operations by:expectedStartTime
fromrateLimiter.Expected()
within the test functionRecordWriteCoFixedLatency
after successful write operationsRecordReadCoFixedLatency
after successful read operationsendTime.Sub(expectedStartTime)
This ensures HDR histogram files now include all expected tags:
raw
,co-fixed
,raw-read
,co-fixed-read
,raw-write
,co-fixed-write
.Changes Made
Testing
The changes are minimal and focused, affecting only the mixed mode latency recording without altering any other functionality.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.