Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 25, 2025

Problem Fixed

The mixed mode was missing "co-fixed-read" and "co-fixed-write" tags in HDR histogram output because the DoMixed function wasn't calling RecordReadCoFixedLatency and RecordWriteCoFixedLatency methods.

Solution

Modified DoMixed function in modes.go to calculate and record coordinated omission fixed latency for both read and write operations by:

  1. Retrieving expectedStartTime from rateLimiter.Expected() within the test function
  2. Calling RecordWriteCoFixedLatency after successful write operations
  3. Calling RecordReadCoFixedLatency after successful read operations
  4. Calculating co-fixed latency as endTime.Sub(expectedStartTime)

This ensures HDR histogram files now include all expected tags: raw, co-fixed, raw-read, co-fixed-read, raw-write, co-fixed-write.

Changes Made

  • modes.go: Fixed mixed mode coordinated omission fixed latency recording
  • modes_test.go: Added test for mixed mode latency recording logic

Testing

  • ✅ All existing tests continue to pass
  • ✅ New test validates coordinated omission calculation logic
  • ✅ Build process completes successfully
  • ✅ Mixed mode now properly records both raw and coordinated omission fixed latency for read and write operations

The changes are minimal and focused, affecting only the mixed mode latency recording without altering any other functionality.

Original prompt

This section details on the original issue you should resolve

<issue_title>New added "mixed" load: results has no "co-fixed-read" and "co-fixed-write" tags</issue_title>
<issue_description>After merging of #211
I created local scylla-bench image on top of "master", as:

DOCKER_IMAGE_TAG=mixed_load make build-docker-image

And ran mixed load with command below and saved HDR results in the file:

docker run -it -v /home/juliayakovlev/Downloads:/home --rm --network=host mixed_load -workload uniform -mode mixed -nodes 127.0.0.1 -concurrency 64 -duration 300s --hdr-latency-file=/home/hdrh-scyllabench-mixed.hdr

This is the result file:
hdrh-scyllabench-mixed.hdr.log

The flags in the results file are:

  • co-fixed
  • raw
  • raw-read
  • raw-write

I did not find tags "co-fixed-read" and "co-fixed-write".

And what is the difference between "raw" and "co-fixed"?</issue_description>

<agent_instructions>check why some of the tags are missing from the PR recently merged</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #214

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

…istograms

Co-authored-by: fruch <340979+fruch@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] New added "mixed" load: results has no "co-fixed-read" and "co-fixed-write" tags Fix missing co-fixed-read and co-fixed-write tags in mixed mode HDR histograms Sep 25, 2025
@Copilot Copilot AI requested a review from fruch September 25, 2025 13:59
Copilot finished work on behalf of fruch September 25, 2025 13:59
@fruch fruch requested review from CodeLieutenant and removed request for fruch September 25, 2025 13:59
@fruch
Copy link
Contributor

fruch commented Sep 25, 2025

@CodeLieutenant can you follow @copilot into fixing this one ? and let @juliayakovlev try it to confirm it's working as expected

Co-authored-by: fruch <340979+fruch@users.noreply.github.com>
@Copilot Copilot AI requested a review from fruch September 25, 2025 14:05
Copilot finished work on behalf of fruch September 25, 2025 14:05
Copilot finished work on behalf of fruch September 25, 2025 14:07
Co-authored-by: fruch <340979+fruch@users.noreply.github.com>
Copilot finished work on behalf of fruch September 25, 2025 14:15
@juliayakovlev
Copy link

@CodeLieutenant can you follow @copilot into fixing this one ? and let @juliayakovlev try it to confirm it's working as expected

I re-run the test with new created docker image.
hdrh-scyllabench-mixed.hdr.log

Missed co-fixed-write and co-fixed-read tags are found.
But there are 2 questions:

@CodeLieutenant CodeLieutenant marked this pull request as ready for review October 6, 2025 07:43
@CodeLieutenant CodeLieutenant merged commit 7430da9 into master Oct 10, 2025
2 checks passed
@CodeLieutenant CodeLieutenant deleted the copilot/fix-8e110fe4-bfcb-46aa-b8bc-21f68dde03b1 branch October 10, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New added "mixed" load: results has no "co-fixed-read" and "co-fixed-write" tags

4 participants