feature(report-policy): Report the Scylla Host Selection Policy #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
dimakr
reviewed
Aug 20, 2025
2 tasks
juliayakovlev
approved these changes
Sep 14, 2025
|
@dimakr can you review, please. This commit looks stuck |
|
Also some tests are failed |
|
The change looks good but the tests should be adjusted to work with updated number of returned values by the newHostSelectionPolicy (3 after the change), here Line 225 in 738a2fd |
…eport-host-policy
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting which fallback policy is used when
token-awareis selectedCloses #198