Skip to content

(chore): Re-introduce strict warnings #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 28, 2025
Merged

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jul 23, 2025

No clue why the tests fail. Looks like an issue with some dependency in the min-vers job.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.60%. Comparing base (c29100d) to head (8c30dac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_io/read.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
+ Coverage   87.57%   87.60%   +0.02%     
==========================================
  Files          46       46              
  Lines        7076     7049      -27     
==========================================
- Hits         6197     6175      -22     
+ Misses        879      874       -5     
Files with missing lines Coverage Δ
src/anndata/_io/specs/methods.py 91.05% <100.00%> (ø)
src/anndata/_io/read.py 81.95% <60.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flying-sheep flying-sheep requested a review from ilan-gold July 24, 2025 13:21
@flying-sheep
Copy link
Member Author

flying-sheep commented Jul 28, 2025

@ilan-gold one failure left! Any idea where NullTerminatedBytes comes from and if that warning is expected or not?

zarr.core.dtype.common.UnstableSpecificationWarning: The data type (NullTerminatedBytes(length=10)) does not have a Zarr V3 specification. That means that the representation of arrays saved with this data type may change without warning in a future version of Zarr Python. Arrays stored with this data type may be unreadable by other Zarr libraries. Use this data type at your own risk! Check https://github.com/zarr-developers/zarr-extensions/tree/main/data-types for the status of data type specifications for Zarr V3.

@ilan-gold
Copy link
Contributor

It means we're using https://github.com/zarr-developers/zarr-python/blob/a0c56fbbba12ca4402de3d83043e5f840406d670/src/zarr/core/dtype/npy/bytes.py#L166 but where exactly we are using it I don't know. Maybe within a structured data type?

@flying-sheep flying-sheep changed the title Re-introduce strict warnings (chore): Re-introduce strict warnings Jul 28, 2025
@flying-sheep flying-sheep requested a review from ilan-gold July 28, 2025 09:39
@flying-sheep flying-sheep added this to the 0.12.2 milestone Jul 28, 2025
@flying-sheep flying-sheep merged commit 40b6ccf into main Jul 28, 2025
19 of 24 checks passed
@flying-sheep flying-sheep deleted the pa/fix-strict-warnings branch July 28, 2025 15:43
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Jul 28, 2025
flying-sheep added a commit that referenced this pull request Jul 28, 2025
Co-authored-by: Philipp A <flying-sheep@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants