(fix): setting on Dataset2D
"just works" (like Dataframes) and is thoroughly checked
#1992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're enforcing two dimensions on the object (in theory), we should probably be super clear about that while also retaining dataframe-like operations i.e., when you try to "set a column" (in this case, xarray data variable that isn't a coord), it "just works" (sets the column and doesn't do anything else). This behavior matches that of
pandas
in so far as having a named index doesn't mean it can be set/accessed viadf["my_named_index"]
I think there are probably other horrifying ways to invalidate this constraint, so I will try to comb through the xarray docs to fix these separately, but trying to keep this scoped to the issue for now
Dataset2D
without specificedcoord
#1990