-
Notifications
You must be signed in to change notification settings - Fork 164
(feat): zarr
v3 guide
#1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): zarr
v3 guide
#1948
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
===========================================
+ Coverage 24.85% 84.79% +59.93%
===========================================
Files 46 47 +1
Lines 6904 6918 +14
===========================================
+ Hits 1716 5866 +4150
+ Misses 5188 1052 -4136
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the text is mostly great, nicely structured! I commented on the few cases where I got confused.
First of all it’s always nice when a PR is about 1-2 docs pages to provide links in your initial PR comment (“PR body”? I never know how to refer to that text box).
Something like
### [Rendered](https://icb-anndata--1948.com.readthedocs.build/en/1948/zarr-v3.html)
Please start using one sentence per line in markup documents, that way I can actually comment on what I want to comment on instead of one giant paragraph. I did it myself this time so I could comment.
Please also use typography:
- En-dashes: “–” (very easy to type on your MacBook: Alt/option+-)
- Times symbol: “×” (avoids confusion between
AnnData.X
and factors like “2×”)
Co-authored-by: Philipp A. <flying-sheep@web.de>
Co-authored-by: Philipp A. <flying-sheep@web.de>
@flying-sheep I update the notebook a bit to use the new public data url and also added a note about |
Co-authored-by: Philipp A. <flying-sheep@web.de>
Co-authored-by: Philipp A. <flying-sheep@web.de>
docs/tutorials/zarr-v3.md
Outdated
|
||
Local data generally poses a different set of challenges. | ||
First, write speeds can be somewhat slow and second, the creation of many small files on a file system can slow down a filesystem. | ||
For the "many small files" problem, `zarr` has introduced `{ref} sharding <zarr:user-guide-sharding>` in the v3 file format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good apart from the broken syntax, please fix that before merging
d7350c9
to
1f25a0d
Compare
Rendered