改良测试用环境 #521
Draft
改良测试用环境 #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyfung1031
force-pushed
the
patch_-createTestContext
branch
from
2cf492d to
bfa2712
Compare
|
我觉得之前的没问题，这里的测试是针对GM API的，需要权限设定的有在 https://github.com/scriptscat/scriptcat/blob/main/src/app/service/content/exec_script.test.ts 覆盖，另外专门弄一个测试函数来实例化GMApi，不是很符合正常流程，我觉得不太妥 |
CodFrm
force-pushed
the
main
branch
2 times, most recently
from
dc35ec8 to
26c0569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改良前：直接new API
改良後：跟實際一樣需要權限設定