Skip to content

Conversation

kai-kystverket
Copy link

@kai-kystverket kai-kystverket commented Apr 3, 2025

Added a before property to the container schema to allow ordered executions. This would be implemented as example init container in k8s or depends_on in docker compose.

Description

Added two new fields

  • container: A reference to another container which should be run before
  • status: The status check to decide when to start the container.

What does this PR do?

Implements #104

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: kai-kystverket <kai.andrev.hanssen@kystverket.no>
@kai-kystverket kai-kystverket marked this pull request as ready for review April 7, 2025 08:53
@mathieu-benoit
Copy link
Contributor

@astromechza, like discussed let's review and merge this one as it will unlock a lot of good use cases with "initContainers".

@mathieu-benoit mathieu-benoit marked this pull request as draft April 25, 2025 17:34
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Apr 25, 2025

Converting back to draft as we want to manually integrate this new version of the spec in the score-go repo and then manually test this new version in score-compose for example. Once this first loop of tests is done, we'll merge/release everyone. It will take some times from here, but we want to avoid breaking change, etc. with existing implementations.

Update: score-go branch/PR now in place: score-spec/score-go#121.

@mathieu-benoit mathieu-benoit linked an issue May 8, 2025 that may be closed by this pull request
@mathieu-benoit mathieu-benoit changed the title Added before property to container for ordered containers Ordered Container Start in Score - containers.*.before.containers|ready Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Ordered Container Start in Score

2 participants