Changes made for confusing message of score generate command #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @chris-stephenson , I made some changes could you please review it. If you have time ? |
lekaf974
reviewed
May 13, 2025
lekaf974
reviewed
May 13, 2025
lekaf974
reviewed
May 13, 2025
lekaf974
reviewed
May 13, 2025
mathieu-benoit
requested changes
May 14, 2025
There was a problem hiding this comment.
Thanks @rabelmervin! I requested some changes, what do you think?
Signed-off-by: rabelmervin <rabelmervin@gmail.com>
mathieu-benoit
requested changes
May 16, 2025
There was a problem hiding this comment.
Thanks @rabelmervin.
To complete the updates in the README.md you also need to do the exact same updates in the actual command itself in this file: https://github.com/score-spec/score-compose/blob/main/internal/command/generate.go. The associated unit test in generate_tests.go will need to be updated accordingly too.
Thanks!
|
Hi @rabelmervin, any update on this one? |
|
Hi @mathieu-benoit sorry no update currently, as I was fighting with semester exams. But, I'll make an update very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287