Skip to content

duply: New completion #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

duply: New completion #221

wants to merge 1 commit into from

Conversation

jose1711
Copy link

No description provided.

Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very brief review, just to get some obvious things out of the way:

  • Most importantly: have you considered and/or tried submitting this for inclusion with upstream duply instead of here? Especially with the lists of hardcoded commands, chained command, and options, this would be better placed there.
  • Coding style (indentation amount, use of line wrapping after if etc, is not consistent with the rest of our completions.
  • Should use our _init_completion mechanism.
  • Leakage of variables (local missing): commands, chained_commands, may_continue, comp_commands, sep, command and probably some more.
  • Test suite addition missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants