Skip to content

feat(ip): Complete ip route list options #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

yedayak
Copy link
Collaborator

@yedayak yedayak commented Apr 30, 2024

No description provided.

@scop
Copy link
Owner

scop commented May 8, 2024

@yedayak I see this PR is marked a draft, but can't spot a TODO note anywhere, is the draft state intentional?

Also, a conflict has cropped up, could you look into it? I'm planning a new release once we get the few new currently open PR's in.

@yedayak
Copy link
Collaborator Author

yedayak commented May 8, 2024

@yedayak I see this PR is marked a draft, but can't spot a TODO note anywhere, is the draft state intentional?

Also, a conflict has cropped up, could you look into it? I'm planning a new release once we get the few new currently open PR's in.

Yeah, I just anticipated the merge conflicts so left it as a draft.
I resolved the conflicts and added a case I missed (scope), marking this as ready.

@yedayak yedayak marked this pull request as ready for review May 8, 2024 17:25
Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scop scop merged commit 43beafc into scop:main May 8, 2024
7 checks passed
@yedayak yedayak deleted the ip-link-list branch January 22, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants