refactor(rmmod): deprecate in favor of upstream one in >= 34

evelikov · evelikov · commit 7679bbfbe167 · 2024-11-08T16:23:44.000Z
Issue: #1246 Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
diff --git a/completions/Makefile.am b/completions/Makefile.am
@@ -376,7 +376,7 @@ bashcomp_DATA = 2to3 \
 		_rg \
 		ri \
 		rmlist \
-		rmmod \
+		_rmmod \
 		route \
 		rpcdebug \
 		rpm \
diff --git a/completions/_rmmod b/completions/_rmmod
@@ -1,6 +1,9 @@
 # Linux rmmod(8) completion.                               -*- shell-script -*-
 # This completes on a list of all currently installed kernel modules.
 
+# Use of this file is deprecated.
+# Upstream completion is available in kmod >= 34, use that instead.
+
 _comp_cmd_rmmod()
 {
     local cur prev words cword comp_args
diff --git a/test/fallback/completions/Makefile.am b/test/fallback/completions/Makefile.am
@@ -33,6 +33,7 @@ EXTRA_DIST = \
 	renice \
 	repomanage \
 	reptyr \
+	rmmod \
 	rfkill \
 	rtcwake \
 	ruff \
diff --git a/test/fallback/completions/rmmmod b/test/fallback/completions/rmmmod
@@ -0,0 +1 @@
+../../../completions/_rmmod

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	`# Linux rmmod(8) completion. -- shell-script --`
`2`	`2`	`# This completes on a list of all currently installed kernel modules.`
`3`	`3`
	`4`	`+# Use of this file is deprecated.`
	`5`	`+# Upstream completion is available in kmod >= 34, use that instead.`
	`6`	`+`
`4`	`7`	`_comp_cmd_rmmod()`
`5`	`8`	`{`
`6`	`9`	`local cur prev words cword comp_args`