refactor(insmod): deprecate in favor of upstream one in >= 34

evelikov · evelikov · commit c7213bd643dd · 2024-11-08T16:23:44.000Z
Issue: #1246 Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
diff --git a/completions/.gitignore b/completions/.gitignore
@@ -139,7 +139,7 @@
 /_incus
 /_infracost
 /inotifywatch
-/insmod.static
+/_insmod.static
 /iperf3
 /_istioctl
 /javac
diff --git a/completions/Makefile.am b/completions/Makefile.am
@@ -181,7 +181,7 @@ bashcomp_DATA = 2to3 \
 		info \
 		inject \
 		inotifywait \
-		insmod \
+		_insmod \
 		installpkg \
 		interdiff \
 		invoke-rc.d \
@@ -688,7 +688,7 @@ CLEANFILES = \
 	_incus \
 	_infracost \
 	inotifywatch \
-	insmod.static \
+	_insmod.static \
 	iperf3 \
 	_istioctl \
 	javac \
@@ -1108,8 +1108,8 @@ symlinks: $(DATA)
 		pinfo
 	$(ss) inotifywait \
 		inotifywatch
-	$(ss) insmod \
-		insmod.static
+	$(ss) _insmod \
+		_insmod.static
 	$(ss) iperf \
 		iperf3
 	$(ss) java \
diff --git a/completions/_insmod b/completions/_insmod
@@ -1,5 +1,8 @@
 # Linux insmod(8) completion                               -*- shell-script -*-
 
+# Use of this file is deprecated.
+# Upstream completion is available in kmod >= 34, use that instead.
+
 _comp_cmd_insmod()
 {
     local cur prev words cword comp_args
diff --git a/test/fallback/completions/Makefile.am b/test/fallback/completions/Makefile.am
@@ -13,6 +13,7 @@ EXTRA_DIST = \
 	gsctl \
 	hexdump \
 	hwclock \
+	insmod \
 	ionice \
 	jungle \
 	keyring \
diff --git a/test/fallback/completions/insmod b/test/fallback/completions/insmod
@@ -0,0 +1 @@
+../../../completions/_insmod

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`# Linux insmod(8) completion -- shell-script --`
`2`	`2`
	`3`	`+# Use of this file is deprecated.`
	`4`	`+# Upstream completion is available in kmod >= 34, use that instead.`
	`5`	`+`
`3`	`6`	`_comp_cmd_insmod()`
`4`	`7`	`{`
`5`	`8`	`local cur prev words cword comp_args`