Skip to content

Conversation

Nydauron
Copy link
Member

Description

Adds type checking to the reporter Cog to prevent exceptioning within the on_error error handler.

Exceptioning has caused any command that raised a CommandInvokeError exception to timeout with:

The application did not respond
image

Checks

  • I ran black over the code to ensure formatting.
  • I added docstrings to any new modules, classes, and methods.
  • I updated the docstrings of any updated modules, classes, and methods.
  • I added/updated Python typings for any new/updated class and module.
  • I updated the bot version (if necessary).
  • I ran mypy and reviewed any shown errors related to my changes.

Important Info

  • This pull request adds new pip dependencies.
  • This pull request adds new external dependencies.
  • This pull request changes the required versions of some dependencies.

Issues Closed

My pull request closes the following issues:
N/A

Thank You

Thank you for your contribution to Scioly.org! This pull request will be reviewed
in a promptly manner. If not done, please feel free to contact @cbrxyz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant