fix: is-jagged determination patterns miss the brackets #1517
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Hi,
This PR may be trivial so far, since the regex pattern I modified is for determinating whether a branch is jagged, which the result value
is_jaggedis never used at present.I found this mistake when I use
_from_leaves_oneto check whether a branch is jagged or not inuproot-custom, and I think I might as well fix this bug now.My understanding to these patterns is that, when a branch contains arrays, there will be
[dim1][dim2]...patterns in title. As long asdimxis not an integer, the branch is jagged.Expected behavior:
_item_any_patternto find all strings matching the[xxx]pattern._item_dim_patternto check ifxxxis an integer. If not, setis_jaggedtoTrue.Actual behavior (before fixing):
_item_any_patterncaptures all[xxx]-like strings but discards the brackets, only retainingxxx._item_dim_patternrequires the full[xxx]pattern to validatexxx, but since the brackets are already missed, the inputxxxcan never satisfy this pattern.