Skip to content

Conversation

eduardo-rodrigues
Copy link
Member

Hi @jonas-eschle, here are a few more fixes. I still see that the docs are not being deployed and also coverage settings were incorrect and I changed the default branch at https://app.codecov.io/gh/scikit-hep/hepstats/config/general to main. I also updated the CODECOV_TOKEN here in the settings. Let's see how that goes :-).

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (b9cbd64) to head (752044c).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   92.26%   92.15%   -0.12%     
==========================================
  Files          26       26              
  Lines        1267     1274       +7     
==========================================
+ Hits         1169     1174       +5     
- Misses         98      100       +2     
Flag Coverage Δ
unittests 92.15% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eduardo-rodrigues
Copy link
Member Author

OK, I see that coverage was uploaded corrected, see https://app.codecov.io/gh/scikit-hep/hepstats/pull/183. Calling it a day :-).

@eduardo-rodrigues eduardo-rodrigues changed the title Fix missed renamings master -> main Fix uploads of coverage tests, missed renamings master -> main May 20, 2025
Copy link
Contributor

@jonas-eschle jonas-eschle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, thanks! LGTM!

@jonas-eschle jonas-eschle merged commit 8f5d2d5 into main May 21, 2025
11 of 12 checks passed
@jonas-eschle jonas-eschle deleted the eduardo-more-fixes branch May 21, 2025 06:21
@eduardo-rodrigues
Copy link
Member Author

(OK, so the coverage results are now nicely uploaded and being updated 🚀. Remains the issue that the docs are built OK as seen in the CI above but the upload is not working. Best to check with similar set-ups what to fix ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants