Sync SPEC 7 with scipy #397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
force-pushed
the
sync-spec7-with-scipy
branch
from
02bd475 to
129a4d1
Compare
|
CI failure seems unrelated: |
|
yeap, ignore the CI for now (and it doesn't matter here anyway as the code is not run in the page just included verbatim) |
bsipocz
reviewed
Jul 2, 2025
There was a problem hiding this comment.
The code itself looks reasonable, but this made me open #399 to question if we should have this code in the SPEC doc to begin with.
(and as the discussion in the scipy thread shows, it's not obvious if the preference is to keep or drop the keywords from the signature.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: scipy/scipy#23276