-
Notifications
You must be signed in to change notification settings - Fork 54
add PR template for new SPECs #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
drammock
wants to merge
2
commits into
scientific-python:main
Choose a base branch
from
drammock:pr-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<!-- Thanks for proposing a new SPEC! Make sure your PR title is descriptive and short. --> | ||
|
||
## Attestation | ||
|
||
- [ ] I have read and understood the [SPEC Purpose and Process](https://scientific-python.org/specs/purpose-and-process/) guidelines | ||
|
||
## Description | ||
|
||
<!--- Please summarize the purpose of this new SPEC, in 1-3 sentences. --> | ||
|
||
## Link to SPEC Committee's "viability" discussion thread (required) | ||
|
||
<!-- | ||
Insert a link to this proposal's initial viability discussion thread in | ||
https://discuss.scientific-python.org/c/specs/ideas | ||
--> | ||
|
||
## Link to "public comments" discussion thread (required) | ||
|
||
<!-- | ||
insert a link to this proposal's community-wide discussion thread in | ||
https://discuss.scientific-python.org/c/specs/web-comments | ||
--> | ||
|
||
## Description of (or link to) exploratory discussions/POCs (optional) | ||
|
||
<!-- | ||
SPEC guidelines suggest a first step of one of the following: | ||
|
||
1. discuss the idea with at least one project in the ecosystem, | ||
1. discuss the idea with at least one other member of the ecosystem, or | ||
1. create a minimal, proof of concept (POC) prototype. | ||
|
||
(see https://scientific-python.org/specs/purpose-and-process/#new-spec-proposals). | ||
In this field, include a description of those preliminary steps and/or links to public discussions or POCs. | ||
--> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
If you are opening this PR to propose a new SPEC, please go to the `Preview` tab, | ||
then [click here for the new SPEC templatee](?expand=1&template=new_spec.md). | ||
Otherwise, delete this text and proceed with your PR as normal. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If folks do like it, we should fix this typo before merging: