feat(SP-2487): Implement path obfuscation #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctFilePathFromWFPBlock()`
isasmendiagus
requested review from
agustingroh and
eeisegn
and removed request for
agustingroh
agustingroh
reviewed
May 23, 2025
| @@ -165,7 +168,7 @@ public void run() { | |||
| .hiddenFilesFolders(allHidden).numThreads(numThreads).url(apiUrl).apiKey(apiKey) | |||
| .retryLimit(retryLimit).timeout(Duration.ofSeconds(timeoutLimit)).scanFlags(scanFlags) | |||
| .sbomType(sbomType).sbom(sbom).snippetLimit(snippetLimit).customCert(caCertPem).proxy(proxy).hpsm(enableHpsm) | |||
| .settings(settings) | |||
| .settings(settings).obfuscate(obfuscate) | |||
There was a problem hiding this comment.
Should we add the new attribute in a new line?
i.e
.settings(settings)
.obfuscate(obfuscate)
agustingroh
reviewed
May 23, 2025
| } | ||
| return ""; | ||
|
|
||
| String result = scanApi.scan(wfp, "", 1); |
There was a problem hiding this comment.
Should we use a constant here?
Suggested:
private final static int ID
private final static int SCANNER_ID
agustingroh
reviewed
May 23, 2025
| /** | ||
| * Resolves the real file path for a given obfuscated path. | ||
| * This method is thread-safe and can be called concurrently from multiple threads. | ||
| * If the provided path is not found in the obfuscation map, the original path is returned. |
There was a problem hiding this comment.
Is this comment right?
should be "If the original path is not found in the obfuscation map, the obfuscated path is returned." ?
|
This is a result of path obfuscation: All looks good |
eeisegn
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
See image:
