Skip to content

Integrate data browser lib #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: development/4.1
Choose a base branch
from
Draft

Integrate data browser lib #978

wants to merge 18 commits into from
+8,523 −4,317

Conversation

@ziyang-lin-404
Copy link
Contributor

@ziyang-lin-404 ziyang-lin-404 commented Oct 30, 2025

We will migrate the entire data-browser module to @scality/data-browser-library.
This PR refactors the ISV Actions section with the new package.

@bert-e
Copy link
Contributor

bert-e commented Oct 30, 2025

Hello ziyang-lin-404,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 30, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ziyang-lin-404
Add alias for 'redux-thunk' in rspack.config.ts to resolve module path
11e8727
@ziyang-lin-404
Add support for JavaScript files in rspack.config.ts to handle data-b…
58c1d47 
…rowser-library
@ziyang-lin-404
Fix race condition and optimize S3 config caching
c581ebd
@ziyang-lin-404
Improve async/await consistency in mutations
762695c
@ziyang-lin-404
Add S3 operations abstraction layer with hook factory
3e36dc7
@ziyang-lin-404
Make useMultiMutation compatible with React Query v3/v5
0003eb5
@ziyang-lin-404
Add ISV operation config and data browser wrapper
138dcf7
@ziyang-lin-404
Migrate ISV to use new S3 hooks architecture
208f08c
@ziyang-lin-404
Refactor ISVApplyActions to integrate new S3 hooks and enhance config…
a7f5b5e 
…uration handling
@ziyang-lin-404
Update @scality/data-browser-library to version 1.0.0-preview.8
42e2beb 
^ Conflicts:
^	package-lock.json
^	package.json
@ziyang-lin-404
Add test setup for ISV components and mock dependencies
9d50986
@ziyang-lin-404
Update package-lock.json
d9cbe85
@ziyang-lin-404
Enhance Joi validation compatibility with TypeScript by updating reso…
cfdbb36 
…lver options and adding type declarations for @hapi/joi integration with react-hook-form.
@ziyang-lin-404
Enhance test utilities by mocking ResizeObserver and getBoundingClien…
3da2b4b 
…tRect for virtual scrolling, and update checkbox test to handle multiple elements.
@ziyang-lin-404 ziyang-lin-404 force-pushed the feature/integrate-data-browser-lib branch from 9005bc2 to 3da2b4b Compare October 30, 2025 22:23
@ziyang-lin-404
Refactor useMultiMutation to enhance type safety and compatibility wi…
d6da32f 
…th React Query v3 and v5 by introducing a generic Mutation type and updating state management.
@ziyang-lin-404
Refactor DataBrowserIsolatedWrapper and related components to utilize…
4265c2b 
… S3ConfigProvider, enhancing configuration management and isolating React Query v5. Remove S3HookFactoryProvider and update tests accordingly.
@ziyang-lin-404
Refactor ISVApplyActions and related hooks to replace useMemo with us…
2c51bd8 
…eEffect for better state management and update mutation handling in useMultiMutation and useMutationActions for improved clarity and functionality.
@ziyang-lin-404
Refactor S3 hooks in DataBrowserHookFactory to improve parameter hand…
925ce5b 
…ling and reduce redundancy by introducing enrichParams function. Update ISVApplyActions to remove unnecessary region dependency in useEffect.
@ziyang-lin-404 ziyang-lin-404 marked this pull request as draft November 3, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ziyang-lin-404 @bert-e