impr(ARSN-529): Add RateLimitConfiguration to BucketInfo #2568
Conversation
Hello tmacro,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/8.2 #2568 +/- ##
===================================================
- Coverage 71.40% 71.39% -0.01%
===================================================
Files 221 222 +1
Lines 17816 17851 +35
Branches 3705 3713 +8
===================================================
+ Hits 12721 12745 +24
- Misses 5091 5102 +11
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
are we sure about the target branch 8.3 is not released yet with stable aws sdk upgrade, we might not be able to test. |
I am okay, we have a feature branch in cloudserver, which we can test on. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
| 200, log); | ||
| }); | ||
| } else if (query['rate-limit'] !== undefined) { | ||
| api.callApiMethod('bucketGetRateLimit', request, response, |
There was a problem hiding this comment.
Shouldn't this be bucketPutRateLimit
| } else if (query?.quota !== undefined) { | ||
| return call('bucketDeleteQuota'); | ||
| } else if (query?.['rate-limit'] !== undefined) { | ||
| return call('bucketDeleteQuota'); |
There was a problem hiding this comment.
for this one, bucketDeleteRateLimit?
|
|
||
| export const NoSuchRateLimitConfig: ErrorFormat = { | ||
| code: 404, | ||
| description: 'The specified bucket does not have a rate limit configuration.', |
There was a problem hiding this comment.
This one is more compact, what do you think?
(also looking at other configuration messages
The bucket rate limit configuration does not exist.
There was a problem hiding this comment.
or
The bucket rate limit configuration was not found
like:
The object lock configuration was not found'
The replication configuration was not found
No description provided.