Skip to content

Update CI configurations #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Update CI configurations #34

merged 2 commits into from
Apr 30, 2025

Conversation

kota2and3kan
Copy link
Collaborator

@kota2and3kan kota2and3kan commented Apr 28, 2025

Description

This PR updates the manifests file for CI as follows:

  • Change the container image of ScalarDL Auditor.
    • Recently, we updated the default container image of ScalarDL on the Helm Chart side. Now, it uses ghcr.io/scalar-labs/scalardl-auditor-byol by default, which requires a license key to run. However, in the CI environment, we don't set the license key. So, the CI fails.
    • To address this issue, I specified the container image ghcr.io/scalar-labs/scalardl-auditor explicitly. This image does not require the license key since it's for internal developers.
  • Set imagePullSecrets for ScalarDB Server.
    • Recently, we updated the visibility of the ScalarDB Server container registry from public to private because it's already deprecated. As a result, we need credentials to pull the container image of ScalarDB Server.
    • To address this issue, I specified the imagePullSecrets to set credentials. This configuration allows the CI environment to pull the private container images.

Please take a look!

Related issues and/or PRs

Changes made

  • Set ghcr.io/scalar-labs/scalardl-auditor in the custom values file for CI.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@kota2and3kan kota2and3kan self-assigned this Apr 28, 2025
@kota2and3kan kota2and3kan changed the title Update container image of ScalarDL Auditor in CI Update CI configurations Apr 28, 2025
Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@kota2and3kan
Copy link
Collaborator Author

kota2and3kan commented Apr 30, 2025

Copilot Test!


This pull request introduces updates to Kubernetes manifests for ScalarDB and ScalarDL Auditor to enhance configuration flexibility and facilitate container image management. The most notable changes involve the addition of imagePullSecrets for ScalarDB and specifying the container image repository for the ScalarDL Auditor.

Updates to ScalarDB manifest:

  • Added imagePullSecrets to the ScalarDB manifest to enable pulling container images from private registries. (.github/manifests/scalardb.yaml, .github/manifests/scalardb.yamlR2-R3)

Updates to ScalarDL Auditor manifest:

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@feeblefakie feeblefakie merged commit c7de215 into main Apr 30, 2025
10 checks passed
@feeblefakie feeblefakie deleted the update-container-images-in-ci branch April 30, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants