Fix CI for external PRs #8766
Fix CI for external PRs #8766
Conversation
📝 Walkthrough""" WalkthroughThe GitHub Actions workflow for building, testing, and deploying Docker images was updated to add stricter conditions for Docker login and image push steps. These steps now exclude runs by Dependabot and require that pull request sources match the base repository, in addition to existing tag reference checks. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build_test_deploy.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/build_test_deploy.yml
274-274: if: condition "${{ ! startsWith(github.ref, 'refs/tags/') }} && github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository\n" is always evaluated to true because extra characters are around ${{ }}
(if-cond)
293-293: if: condition "${{ ! startsWith(github.ref, 'refs/tags/') }} && github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository\n" is always evaluated to true because extra characters are around ${{ }}
(if-cond)
312-312: if: condition "${{ ! startsWith(github.ref, 'refs/tags/') }} && github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository\n" is always evaluated to true because extra characters are around ${{ }}
(if-cond)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-smoketest-push
- GitHub Check: backend-tests
- GitHub Check: frontend-tests
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
.github/workflows/build_test_deploy.yml (2)
265-268:docker/login-actioncondition is fixed but duplication issue remains
The expression is now syntactically correct – nice!
However, the very same predicate is still copy-pasted to every subsequentdocker pushstep. The DRY refactor suggested in earlier reviews (extract intoenv.SHOULD_PUSHor aneeds.output) is still valid and would remove 6× duplicated logic.
282-283: Repeated conditional expression – see earlier DRY suggestion
These four blocks repeat the exact same predicate that already appears in lines 265-268 and 290-293. Consolidating it into one reusable variable will lower maintenance cost and eliminate future copy-paste errors.Also applies to: 299-301, 307-309, 316-317
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build_test_deploy.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/build_test_deploy.yml
273-273: parser did not reach end of input after parsing the expression. 29 remaining token(s) in the input: "IDENT", ".", "IDENT", "!=", "STRING", "&&", "(", "IDENT", ".", "IDENT", "!=", "STRING", "||", "IDENT", ".", "IDENT", ".", "IDENT", ".", "IDENT", ".", "IDENT", ".", "IDENT", "==", "IDENT", ".", "IDENT", ")"
(expression)
Steps to test:
Context
https://scm.slack.com/archives/C5AKLAV0B/p1751984023867249?thread_ts=1751275996.327659&cid=C5AKLAV0B
Issues: