Skip to content

upgrade backend dependencies; run codespell #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 28, 2025

Some housekeeping. CI should be enough. I tested that downloaded NMLs still look right.

@fm3 fm3 self-assigned this May 28, 2025
Copy link
Contributor

coderabbitai bot commented May 28, 2025

📝 Walkthrough

Walkthrough

This update revises several project dependencies and plugins to newer versions, corrects minor spelling mistakes in code comments, and updates configuration files for build tools and spell checking. No functional or logical code changes are introduced, and only one new private variable is added to centralize a dependency version.

Changes

Files/Paths Change Summary
.codespellrc Added "InOut" to the ignore-words-list for codespell.
build.sbt Updated Scapegoat plugin version from 3.1.8 to 3.1.9.
project/build.properties Updated sbt version from 1.10.11 to 1.11.0.
project/plugins.sbt Updated sbt-buildinfo (0.13.0 → 0.13.1) and sbt-scapegoat (1.2.12 → 1.2.13) plugin versions.
frontend/javascripts/test/sagas/volumetracing/volumetracing... Fixed a typo in a comment ("sibiling" → "sibling").
frontend/javascripts/viewer/controller/mesh_helpers.ts Corrected a comment typo ("Similarily" → "Similarly").
util/src/main/scala/com/scalableminds/util/tools/Tristate... Fixed a comment typo ("defualt" → "default").
project/Dependencies.scala Upgraded multiple dependencies (Silhouette, Brotli, Play JSON, Commons Email/IO/Codec, Gson, AWS/GCP SDKs, Zstd, etc.), introduced slickVersion variable, and unified Slick dependencies.

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • frcroth

Poem

A hop and a skip through the code we go,
Updating versions, letting old ones go.
Typos are fixed with a twitch of the nose,
Dependencies blossom, the project grows.
🐇✨
With each little patch, the garden is neat—
The codebase now feels extra sweet!

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fm3 fm3 marked this pull request as ready for review May 28, 2025 17:14
@fm3 fm3 requested a review from frcroth May 28, 2025 17:14
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
project/Dependencies.scala (1)

5-7: Introduce centralized version constants
Defining silhouetteVersion, brotliVersion, and the new slickVersion (3.5.2) reduces duplication and simplifies future upgrades.

Consider adding a brief comment above slickVersion explaining its role in unifying all Slick-related dependencies.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 055c9e2 and 93a92fe.

📒 Files selected for processing (8)
  • .codespellrc (1 hunks)
  • build.sbt (1 hunks)
  • frontend/javascripts/test/sagas/volumetracing/volumetracing_saga_integration_1.spec.ts (1 hunks)
  • frontend/javascripts/viewer/controller/mesh_helpers.ts (1 hunks)
  • project/Dependencies.scala (5 hunks)
  • project/build.properties (1 hunks)
  • project/plugins.sbt (2 hunks)
  • util/src/main/scala/com/scalableminds/util/tools/TristateOptionJsonHelper.scala (1 hunks)
🔇 Additional comments (13)
.codespellrc (1)

6-6: Approve addition of 'InOut' to ignore list.
Adding "InOut" to ignore-words-list prevents codespell from flagging this valid camelCased term.

frontend/javascripts/viewer/controller/mesh_helpers.ts (1)

25-25: Approve typo correction in comment.
Changed "Similarily" to "Similarly" in the class documentation to improve clarity.

frontend/javascripts/test/sagas/volumetracing/volumetracing_saga_integration_1.spec.ts (1)

2-2: Approve typo fix in test comment.
Corrected "sibiling" to "sibling" in the file reference comment; this has no impact on test logic.

util/src/main/scala/com/scalableminds/util/tools/TristateOptionJsonHelper.scala (1)

8-8: Approve comment spelling correction.
Fixed "defualt" to "default" in the usage example comment to align with correct spelling.

project/build.properties (1)

1-1: Approve SBT version update.
Updated sbt.version to 1.11.0 to stay in sync with other build tool upgrades.

build.sbt (1)

5-5: Consistent Scapegoat plugin version bump
The upgrade of scapegoatVersion from 3.1.8 to 3.1.9 aligns with other build‐tool updates in this PR. No conflicting settings detected.

project/plugins.sbt (2)

5-5: Upgrade sbt-buildinfo plugin
Bumped sbt-buildinfo from 0.13.0 to 0.13.1 to match the sbt version upgrade. This is a patch-level change with no breaking API changes.


14-14: Upgrade sbt-scapegoat plugin
Updated sbt-scapegoat from 1.2.12 to 1.2.13, consistent with the scapegoatVersion change in build.sbt. All configurations remain valid.

project/Dependencies.scala (5)

15-15: Upgrade utilDependencies versions & verify Play JSON 3.x compatibility

  • play-json → 3.0.4
  • commons-email → 1.6.0
  • commons-io → 2.19.0

These are patch-level bumps, but note the major version jump of Play JSON (2.x → 3.x). Please ensure existing JSON serialization/deserialization still behaves as expected.

Also applies to: 17-17, 19-19


46-46: Update Gson library
Upgraded com.google.code.gson:gson from 2.10.1 to 2.13.1. No API breaking changes in this patch release.


60-60: Upgrade cloud & compression dependencies

  • software.amazon.awssdk:s3 → 2.31.50
  • com.google.cloud:google-cloud-storage → 2.52.3
  • com.github.luben:zstd-jni → 1.5.7-3

These align with minor/patch releases and should maintain backward compatibility.

Also applies to: 62-62, 68-68


86-86: Bump Commons Codec
Updated commons-codec from 1.17.0 to 1.18.0. A straightforward patch release.


98-109: Standardize and upgrade core backend libraries

  • woodstox-core → 7.1.0
  • jwt-play-json → 10.0.4
  • slick, slick-hikaricp, slick-codegen centralized to version 3.5.2 (slickVersion)
  • postgresql driver → 42.7.5

Centralizing Slick versions is good practice. Ensure that Slick code-generation and database migrations remain compatible with 3.5.2.

@fm3 fm3 merged commit f19b7f8 into master Jun 2, 2025
5 checks passed
@fm3 fm3 deleted the bump-backend-deps-2025-05 branch June 2, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants