-
Notifications
You must be signed in to change notification settings - Fork 27
upgrade backend dependencies; run codespell #8663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis update revises several project dependencies and plugins to newer versions, corrects minor spelling mistakes in code comments, and updates configuration files for build tools and spell checking. No functional or logical code changes are introduced, and only one new private variable is added to centralize a dependency version. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
project/Dependencies.scala (1)
5-7
: Introduce centralized version constants
DefiningsilhouetteVersion
,brotliVersion
, and the newslickVersion
(3.5.2) reduces duplication and simplifies future upgrades.Consider adding a brief comment above
slickVersion
explaining its role in unifying all Slick-related dependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.codespellrc
(1 hunks)build.sbt
(1 hunks)frontend/javascripts/test/sagas/volumetracing/volumetracing_saga_integration_1.spec.ts
(1 hunks)frontend/javascripts/viewer/controller/mesh_helpers.ts
(1 hunks)project/Dependencies.scala
(5 hunks)project/build.properties
(1 hunks)project/plugins.sbt
(2 hunks)util/src/main/scala/com/scalableminds/util/tools/TristateOptionJsonHelper.scala
(1 hunks)
🔇 Additional comments (13)
.codespellrc (1)
6-6
: Approve addition of 'InOut' to ignore list.
Adding "InOut" toignore-words-list
prevents codespell from flagging this valid camelCased term.frontend/javascripts/viewer/controller/mesh_helpers.ts (1)
25-25
: Approve typo correction in comment.
Changed "Similarily" to "Similarly" in the class documentation to improve clarity.frontend/javascripts/test/sagas/volumetracing/volumetracing_saga_integration_1.spec.ts (1)
2-2
: Approve typo fix in test comment.
Corrected "sibiling" to "sibling" in the file reference comment; this has no impact on test logic.util/src/main/scala/com/scalableminds/util/tools/TristateOptionJsonHelper.scala (1)
8-8
: Approve comment spelling correction.
Fixed "defualt" to "default" in the usage example comment to align with correct spelling.project/build.properties (1)
1-1
: Approve SBT version update.
Updatedsbt.version
to 1.11.0 to stay in sync with other build tool upgrades.build.sbt (1)
5-5
: Consistent Scapegoat plugin version bump
The upgrade ofscapegoatVersion
from 3.1.8 to 3.1.9 aligns with other build‐tool updates in this PR. No conflicting settings detected.project/plugins.sbt (2)
5-5
: Upgrade sbt-buildinfo plugin
Bumpedsbt-buildinfo
from 0.13.0 to 0.13.1 to match the sbt version upgrade. This is a patch-level change with no breaking API changes.
14-14
: Upgrade sbt-scapegoat plugin
Updatedsbt-scapegoat
from 1.2.12 to 1.2.13, consistent with thescapegoatVersion
change inbuild.sbt
. All configurations remain valid.project/Dependencies.scala (5)
15-15
: Upgrade utilDependencies versions & verify Play JSON 3.x compatibility
play-json
→ 3.0.4commons-email
→ 1.6.0commons-io
→ 2.19.0These are patch-level bumps, but note the major version jump of Play JSON (2.x → 3.x). Please ensure existing JSON serialization/deserialization still behaves as expected.
Also applies to: 17-17, 19-19
46-46
: Update Gson library
Upgradedcom.google.code.gson:gson
from 2.10.1 to 2.13.1. No API breaking changes in this patch release.
60-60
: Upgrade cloud & compression dependencies
software.amazon.awssdk:s3
→ 2.31.50com.google.cloud:google-cloud-storage
→ 2.52.3com.github.luben:zstd-jni
→ 1.5.7-3These align with minor/patch releases and should maintain backward compatibility.
Also applies to: 62-62, 68-68
86-86
: Bump Commons Codec
Updatedcommons-codec
from 1.17.0 to 1.18.0. A straightforward patch release.
98-109
: Standardize and upgrade core backend libraries
woodstox-core
→ 7.1.0jwt-play-json
→ 10.0.4slick
,slick-hikaricp
,slick-codegen
centralized to version 3.5.2 (slickVersion
)postgresql
driver → 42.7.5Centralizing Slick versions is good practice. Ensure that Slick code-generation and database migrations remain compatible with 3.5.2.
Some housekeeping. CI should be enough. I tested that downloaded NMLs still look right.