-
Notifications
You must be signed in to change notification settings - Fork 1.1k
-Vphases takes names to mark, -Vprint is typer #17563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dffc44c
to
84d4dd9
Compare
2fa3c7d
to
6a23cad
Compare
Checking |
6a23cad
to
392a2cf
Compare
The wild error:
https://github.com/scala/scala3/actions/runs/11796179302/job/32857488523?pr=17563 Edit: it was deprecated since 9 and removed in 21, stale interface for JIT. This is where a mechanism to exclude API from compilation would really shine. |
Scala 2 partest supports testing plugins by taking Currently there is no automated test for |
Drafting to solve In Scala 2, a In Scala 3, settings are just strings. Possibly, it is not too late to require Edit: resolved by requiring a "colon arg" if a multivalued (list) option has no default value. That currently applies only to |
de7bd5b
to
94b54e4
Compare
@ckipp01 I think of you every time I return to this PR, which is two years now. So many colors! |
ab6e1f9
to
962d37c
Compare
Distinguish whether a setting was "set" by the user.
962d37c
to
ad89a1f
Compare
-Vphases
optionally takes a list of phase names to highlight in the output.-Vprint
optionally takes a list of phase names for printing, and defaults totyper
.Add plugins and
fuse
before listing-Vphases
, to include plugins in the list. This also honors-Ystop-after
, so the listing shows what will be constructed for aRun
.setting.isPresent
if the user supplied the option;setting.userValue
is the optional value supplied by the user.If a setting has an empty default, an explicit argument must be supplied.
A couple of phase names are normalized to camelCase.
-Vprint
loosely matches the phase name (contains
), so do the same for-Vphases
. (Would be nice to ignore upper/lower case.)E.g.,
-Vphases:checkUnused,elimByName
highlights both phases so that it's easy to find the miniphase of interest.