Skip to content

Refactor, add Ventura support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 171 commits into from
Closed

Refactor, add Ventura support #4

wants to merge 171 commits into from

Conversation

silverailscolo
Copy link
Contributor

@silverailscolo silverailscolo commented Aug 20, 2025 •
edited
Loading

Overview

  • Move model definitions to models/ directory, 1. Move models to folder #9
  • a simple init pytest as a starting point for pymodbus-supported test, 2. Add minimal pytest #10 and More tests #11
  • Automatic indexing of any module in the models/ directory.
  • Streamlined naming of model class .Node and data NodeData.
  • ProductId const enum replaced by dict built at startup from models/ definition files, returning normal int hex, also to HA integration.
  • CLI: model-specific print moved to models/ files. Ventura commands added. Fixed number entry being rejected as text by try int(val) in decode().
  • Duplicate code bundled in bridge module, used by cli and __init__ (integration access).
  • Register Access flags fixed (IntEnum, correctly recognizing R+W+S)
  • Add ClimaRad Ventura model support (common elements and methods in VMD_base.py)
  • Add NO_CAP to capabilities enum to fake the capabilities register, which the HA integration Fan relies on but Ventura does not support..
  • spelling fixes
  • sort imports

Note: will require simultaneous update of homeassistant-airios-component to pick up changes in data received.

I will offer separate PR's so you can merge them (first 2 merged). Full code reads/writes to a device OK by now 😁.

@silverailscolo silverailscolo changed the title WIP: Ventura support WIP: Ventura support/refactor Aug 23, 2025
@silverailscolo
init and CLI get models from bridge, loggers, set_debug, no named mod…
489c918 
… imports
@silverailscolo
clean-up
11b4d7b
@silverailscolo
rename scan_registers
df36ba3
@silverailscolo
refactor models/
8796041
@silverailscolo
fix spelling, masked vars, static method
50f85f1
@silverailscolo
fix imports
1925890
@silverailscolo
sort imports, add pytest toml, tests/1, add req_test.txt, fix CLI+cod…
7813f3e 
…e spelling
@silverailscolo
load named modules from models using glob and dicts
b707d89 
fetch product_id() from model
hide preset dataclass to pass init
add VMD base class
@silverailscolo
add VMD_07RPS13 model file (copy)
8b4e1ab 
adjust CLI to use VMD CLI
@silverailscolo
hardcoded access to Ventura,incorrect registers
3b59515
@silverailscolo
clean
0329d75
@silverailscolo
move all model info to their files, build prompt on the fly from modu…
18bbb8e 
…le name
@silverailscolo
init and CLI get models from bridge, loggers, set_debug, no named mod…
52b12b8 
… imports
@silverailscolo
clean-up
0a341c2
@silverailscolo
rename scan_registers
2ae969d
@silverailscolo
Merge remote-tracking branch 'origin/eb-ventura' into eb-ventura
a7fdc3b
@silverailscolo
add Ventura RF registers
d06e0db
@silverailscolo
clean up unused registers
928eba5
@silverailscolo
update VMDx CLI
3ccb05f
@silverailscolo
expose product_ids, sort imports
a82ea81
@silverailscolo
Copy link
Contributor Author

Had to pull --rebase + fix merge conflicts, but that created 70 extra commits. Better to squash merge this instead of adding all these commits.

Thanks for installing the Lint workflow (see it in my own branch). Will fix the errors 1 by 1. Keeps me focussed ;-)

@silverailscolo silverailscolo marked this pull request as draft September 11, 2025 13:20
@silverailscolo
annotate
abc7831
@silverailscolo
fix init node key lookup, models not modules
fa11f86
@silverailscolo
test docstr, remove unused
a8525d1
@silverailscolo
fix prids in iit, add api_init_test
3078bf6
@silverailscolo
pylint fix cli
960cee8
@silverailscolo
pylint fix models
ab90086
@silverailscolo
pylint fix registers
e323eb6
@silverailscolo
pylint fixes
393a074
@silverailscolo
Merge branch 'main' of https://github.com/scabrero/pyairios into eb-v…
14e6c47 
…entura

# Conflicts:
#	cli.py
#	pyproject.toml
#	src/pyairios/__init__.py
#	src/pyairios/client.py
#	src/pyairios/data_model.py
#	src/pyairios/models/brdg_02r13.py
#	src/pyairios/models/vmd_02rps78.py
#	src/pyairios/models/vmn_05lm02.py
#	tests/test_one.py
@silverailscolo
pymodbus >=3.11.1 for HA
63e1d3d
@silverailscolo
Merge branch 'eb-ventura' of https://github.com/silverailscolo/pyairios…
85a7d32 
… into eb-ventura
@silverailscolo
repair import
cc7beea
@silverailscolo
pick up new tests
9c2e049
@silverailscolo
roll back tests to master
2776be9
@silverailscolo silverailscolo marked this pull request as ready for review September 22, 2025 18:46
@silverailscolo
Copy link
Contributor Author

This package contains all remaining bullets. Is it worth the effort to pull it apart?

  • It puts all model-specific elements into the models files, including CLI node status prints() and product_id & _name;
  • It dynamically collects all supported models into the bridge_data for CLI and api (Home Assistant);
  • It adds Ventura V1 support.

@scabrero
Copy link
Owner

I have started to pick the changes slowly in a new branch on top of main because it is really hard to follow the commits. Please avoid merges in pull requests, always rebase on top of main. I will comment on some changes.

scabrero
scabrero reviewed Sep 22, 2025
View reviewed changes
src/pyairios/registers.py

class RegisterAccess(Flag):
"""Register access flags."""
class RegisterAccess(IntEnum):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The access is a bitmask.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought so, but 3 combined access level flags didn't work, meaning I could not write to an RW register in CLI master.

Perhaps a fix is defining register access flags between extra pair of brackets ( | )

@scabrero
Copy link
Owner

I have started to pick the changes slowly in a new branch on top of main because it is really hard to follow the commits. Please avoid merges in pull requests, always rebase on top of main. I will comment on some changes.

I will push picked changes to https://github.com/scabrero/pyairios/tree/ventura and then merge it, unless you prefer to clean up this and rebase on top of main without merge commits.

@silverailscolo silverailscolo mentioned this pull request Sep 24, 2025
Open
@silverailscolo
Copy link
Contributor Author

I transferred the changes to a fresh branch/PR #12.

To pass all checks, added a number of None checks.
Left out the Access/Flag change.

@silverailscolo
Copy link
Contributor Author

We are continuing in PR #4 , closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scabrero scabrero scabrero left review comments

Assignees

@scabrero scabrero

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@silverailscolo @scabrero