Skip to content

Conversation

Nootybloops
Copy link

  • Updated dockerfile
  • Added minimal peppermint.json to the docker folder, for use by the dockerfile.
  • Updated getting started with alternate docker-compose instructions & troubleshooting.

Nootybloops and others added 3 commits August 22, 2024 02:09
No idea why git didn't pick up this file being added to the repo, but here it is manually uploaded anyway...

Minimal peppermint.json so the dockerfile can use it. :)
Copy link
Owner

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR! I leave some comments below.

1. Build the container (see above) on the machine you want to run the container on.
- Building it on the machine itself means you don't need to worry about motherboard/kernal type, it will build the correct one for that machine.
- If you need to install Apache in order to install PHP so you can build it, remember to turn the 'start on boot' setting off. (Also just turn it off straight away, you don't need it to build.)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use phpX.Y-cli and phpX.Y-zip. You shouldn't need to install Apache to build Pepperminty Wiki?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advice I got from a quick google is the easiest way to install php is to just install Apache? Haven't used PHP for years before I did this, so if there's an actual better way feel free to get rid of that line. (I did manage to confuse myself with it though so idk might be useful, but I THINK I also put it in the troubleshooting so that should be good enough.)

COPY docker/peppermint.json /srv/app/
RUN mkdir -p /srv/data &&\
chown 10801:10801 /srv/data &&\
chown 10801:10801 /srv/app/peppermint.json &&\
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume by doing docker run -v /test/example.json:/srv/app/peppermint.json .... you overwrite this file? I don't quite understand how that would work in the scenario of a -v if the file doesn't exist on the host, and the alternate situation in which peppermint.json does exist on the host

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, yeah, if it's an update you definitely wouldn't want it in there. But for a first run it's extremely useful. I'm not familiar enough with the code to know if there'd be an easy way of putting in some kinda if statement there, but if there is that might be the best option?

sbrl and others added 2 commits September 6, 2024 02:17
NB -> Note

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants