Skip to content

Add persian translation #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
May 6, 2025

Conversation

Alavi1412
Copy link
Contributor

@Alavi1412 Alavi1412 commented Apr 17, 2025

This PR is for adding Persian translation.

@Alavi1412
Copy link
Contributor Author

@nifadyev It seems there were some linting issues that failed the workflow. I have tried to fix them and the workflow should pass now.
Also, the pre-commit is preventing to commit because it found a lot of issues in our existing README.md. I end up disabling the error for the line-length to pass the workflow but I think that needs some special attention.
I would need you to approve again and restart the workflow, please.

@satwikkansal
Copy link
Owner

Thanks for the PR @Alavi1412

@nifadyev the linter is detecting lot of errors, how do you think we should proceed, my feeling is we should fix the easy ones (and the ones high in frequency) and merge, but open to suggestions

@nifadyev
Copy link
Contributor

nifadyev commented May 6, 2025

Hey @Alavi1412 and @satwikkansal , sorry for a late reply
I suppose we should ignore the failing workflow for now. There are too many fixes and changes for a workflow to pass, it should be made separetely. I hope I will find some time for it in next 2 weeks and ping @Alavi1412 to make changes in his translation. Let's merge the translation 🚀

@satwikkansal
Copy link
Owner

Perfect, thanks @nifadyev, merging this!

@Alavi1412 Congratulations on finish the translation, I hope you enjoyed and learned new things about Python during the process :) Thank you so much for doing it! 🚀

@satwikkansal satwikkansal merged commit 482f230 into satwikkansal:master May 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants