Handle ? and # in Sass::GemPackageImporter #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
commented
Oct 25, 2025
| return unless url.start_with?('pkg:') | ||
|
|
||
| library, _, path = url[4..].partition('/') | ||
| library, _, path = url[4..].partition(/[?#]/).first.partition('/') |
Member
Author
There was a problem hiding this comment.
NodePackageImporter would throw an error complaining about querystring or hash, where GemPackageImporter would ignore them for simplicity. Users should not reply on this behavior and should avoid having querystring or hash.
ntkme
commented
Oct 25, 2025
| gem_dir = Gem::Dependency.new(library).to_spec.gem_dir | ||
|
|
||
| "file://#{'/' unless gem_dir.start_with?('/')}#{gem_dir}/#{path}" | ||
| "file://#{'/' unless gem_dir.start_with?('/')}#{gem_dir.gsub(/[?#]/, { '?' => '%3F', '#' => '%23' })}/#{path}" |
Member
Author
There was a problem hiding this comment.
To avoid dragging dependency on URI, this only does the bare minimum encoding to ensure that dart side can parse the full path as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.