Skip to content

Fix: Corrected typo in o4-mini model name and fixed endpoint map #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

bakatz
Copy link
Contributor

@bakatz bakatz commented May 2, 2025

Describe the change
Someone typo'd the O4 mini model name in #968. Fixed it in this PR.

Provide OpenAI documentation link
N/A

Describe your solution
Self-explanatory

Tests
Tests didn't need to be updated as this was a variable naming change only. The underlying model name was correct.

Additional context
See this issue

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (774fc9d) to head (23db2c6).
Report is 98 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #981       +/-   ##
===========================================
- Coverage   98.46%   85.44%   -13.02%     
===========================================
  Files          24       43       +19     
  Lines        1364     2268      +904     
===========================================
+ Hits         1343     1938      +595     
- Misses         15      308      +293     
- Partials        6       22       +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bakatz
Copy link
Contributor Author

bakatz commented May 2, 2025

@sashabaranov please take a look, this should be a quick one (really)

@bakatz bakatz changed the title Fix: Corrected typo in O4Mini20250416 model name and endpoint map. Fix: Corrected typo in o4-mini model name and fixed endpoint map May 2, 2025
@sashabaranov
Copy link
Owner

Thank you!

@sashabaranov sashabaranov merged commit d65f0cb into sashabaranov:master May 3, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants