Skip to content

Add comprehensive unit tests for Akamai metrics functionality #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add comprehensive unit tests for Akamai metrics functionality #941

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7c3f450
fix: Security fixes for Akamai DNS metrics API - Fix URL injection vu…
abdullah-karatas May 26, 2025
ce8bd4f
security: fix domain authorization bypass in Akamai DNS metrics API
abdullah-karatas May 26, 2025
7b24fb5
WIP
notandy May 28, 2025
aa9268e
move everything to generated RPC framework
notandy May 29, 2025
5ecae81
Fix REUSE and go mod tidy
notandy May 30, 2025
a7ba1d5
Added missing parameter
ronchi-oss Jun 11, 2025
1656693
Add comprehensive unit tests for Akamai metrics functionality
abdullah-karatas Jun 11, 2025
d840ef1
fix: use switch statement instead of if-else for datacenter ID compar…
abdullah-karatas Jun 11, 2025
815416f
fix: handle Akamai historical data without explicit timestamps
abdullah-karatas Jul 9, 2025
866f917
fix: remove unused extractMetricName function to satisfy linter
abdullah-karatas Jul 9, 2025
52a4935
fix: add nil check for agent in PendingSync to prevent test panics
abdullah-karatas Jul 9, 2025
a62fe12
refactor: remove non-functional unit tests per team feedback
abdullah-karatas Jul 13, 2025
1bc5e05
fix: resolve Akamai agent startup issues for RPC communication
abdullah-karatas Jul 14, 2025
ea94163
fix: prevent panic when Akamai dataRow has empty datacenters array
abdullah-karatas Jul 15, 2025
ec51ca6
Merge remote-tracking branch 'origin/main' into add-unit-tests-akamai…
abdullah-karatas Jul 16, 2025
b3bf1a8
Merge upstream main into add-unit-tests-akamai-metrics
abdullah-karatas Jul 16, 2025
2315d6b
fix: correct CidrBlocksController initialization after merge
abdullah-karatas Jul 16, 2025
f92a9b3
fix: remove duplicate restapi/** entry in REUSE.toml
abdullah-karatas Jul 18, 2025
e1b8dcc
refactor: remove unused NewCidrBlocksController function
abdullah-karatas Jul 18, 2025
bbb2121
style: remove redundant akamai import alias
abdullah-karatas Jul 18, 2025
c0351c4
style: remove redundant akamaiAgent import alias
abdullah-karatas Jul 18, 2025
1d42796
refactor: remove redundant global akamaiAgent and standalone RPC hand…
abdullah-karatas Jul 18, 2025
028c5a5
refactor: remove unused GetDNSMetricsAkamai RPC method
abdullah-karatas Jul 18, 2025
f72ecfc
fix: remove unused imports after GetDNSMetricsAkamai removal
abdullah-karatas Jul 18, 2025
48edb0e
chore: remove accidentally committed test files
abdullah-karatas Jul 18, 2025
8b2ccb3
fix: address code review feedback in akamai driver
abdullah-karatas Jul 31, 2025
2eff6ac
Merge branch 'main' into add-unit-tests-akamai-metrics
AbdullahKaratas Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions REUSE.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ path = [
"models/**",
"etc/**",
"web/**",
"internal/rpc/**.pb.go",
"restapi/**",
]
precedence = "aggregate"
SPDX-FileCopyrightText = "2022-2025 SAP SE or an SAP affiliate company and andromeda contributors"
Expand Down
63 changes: 29 additions & 34 deletions client/metrics/get_metrics_akamai_total_dns_requests_parameters.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ require (
github.com/cockroachdb/cockroach-go/v2 v2.4.0
github.com/didip/tollbooth v4.0.2+incompatible
github.com/dlmiddlecote/sqlstats v1.0.2
github.com/dre1080/recovr v1.0.3
github.com/getsentry/sentry-go v0.20.0
github.com/go-openapi/errors v0.22.1
github.com/go-openapi/loads v0.22.0
Expand Down Expand Up @@ -72,9 +71,6 @@ require (
github.com/go-openapi/jsonpointer v0.21.0 // indirect
github.com/go-openapi/jsonreference v0.21.0 // indirect
github.com/go-ozzo/ozzo-validation/v4 v4.3.0 // indirect
github.com/gobuffalo/logger v1.0.3 // indirect
github.com/gobuffalo/packd v1.0.0 // indirect
github.com/gobuffalo/packr/v2 v2.8.0 // indirect
github.com/gofrs/uuid/v5 v5.3.2 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/mux v1.8.1 // indirect
Expand All @@ -84,15 +80,10 @@ require (
github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect
github.com/jackc/puddle/v2 v2.2.2 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/karrick/godirwalk v1.15.3 // indirect
github.com/klauspost/compress v1.18.0 // indirect
github.com/lann/builder v0.0.0-20180802200727-47ae307949d0 // indirect
github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 // indirect
github.com/logrusorgru/aurora v0.0.0-20181002194514-a7b3b318ed4e // indirect
github.com/mailru/easyjson v0.9.0 // indirect
github.com/markbates/errx v1.1.0 // indirect
github.com/markbates/oncer v1.0.0 // indirect
github.com/markbates/safe v1.0.1 // indirect
github.com/mattn/go-runewidth v0.0.9 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/mitchellh/mapstructure v1.5.0 // indirect
Expand All @@ -110,12 +101,10 @@ require (
github.com/rabbitmq/amqp091-go v1.10.0 // indirect
github.com/russross/blackfriday/v2 v2.1.0 // indirect
github.com/sergi/go-diff v1.3.1 // indirect
github.com/sirupsen/logrus v1.9.3 // indirect
github.com/stretchr/objx v0.5.2 // indirect
github.com/vmihailenco/msgpack/v5 v5.4.1 // indirect
github.com/vmihailenco/tagparser/v2 v2.0.0 // indirect
github.com/xrash/smetrics v0.0.0-20240521201337-686a1a2994c1 // indirect
github.com/ztrue/tracerr v0.3.0 // indirect
go.mongodb.org/mongo-driver v1.14.0 // indirect
go.opentelemetry.io/otel v1.24.0 // indirect
go.opentelemetry.io/otel/metric v1.24.0 // indirect
Expand All @@ -124,7 +113,6 @@ require (
golang.org/x/crypto v0.38.0 // indirect
golang.org/x/sync v0.14.0 // indirect
golang.org/x/sys v0.33.0 // indirect
golang.org/x/term v0.32.0 // indirect
golang.org/x/text v0.25.0 // indirect
golang.org/x/time v0.11.0 // indirect
gopkg.in/ini.v1 v1.67.0 // indirect
Expand Down
Loading
Loading