Updated sap_vm_provision(kubevirt_vm) #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sap_vm_provision(kubevirt_vm)
- Added assert for kubeconfig
- Unified storageclass to sapstorage for both trident and hpp and
make configurable
- trident: make parameters configurable in role
- Renamed default namespace for VMs to sap
- Define public ssh key explicitly
- fixed network config cloudinit
- added sap_vm_provision_host_specification_plan to sample var file
- make disk access_modes configurable
- make CPU performance settings configurable
marcelmamula
requested changes
Jul 9, 2025
roles/sap_vm_provision/tasks/platform_ansible/kubevirt_vm/execute_provision.yml
Outdated
Show resolved
Hide resolved
roles/sap_vm_provision/tasks/platform_ansible/kubevirt_vm/execute_provision.yml
Outdated
Show resolved
Hide resolved
added 4 commits
July 16, 2025 11:39
|
@newkit Please make sure to run
yaml[indentation]: Wrong indentation: expected 8 but found 9
playbooks/sample-sap-vm-provision-redhat-ocpv.yml:36
fqcn[action-core]: Use FQCN for builtin module actions (assert).
playbooks/sample-sap-vm-provision-redhat-ocpv.yml:38 Use `ansible.builtin.assert` or `ansible.legacy.assert` instead.
yaml[trailing-spaces]: Trailing spaces
playbooks/vars/sample-variables-sap-vm-provision-redhat-ocpv.yml:21 |
|
Linter issues are fixed and deprecated vars are added to initial commit message. |
Please confirm when both PRs are ready for review after all these changes. |
|
With the latest code all my CI tests are successful now. |
marcelmamula
approved these changes
Jul 17, 2025
geetikakay
reviewed
Jul 17, 2025
roles/sap_vm_provision/tasks/platform_ansible/kubevirt_vm/execute_main.yml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated sap_vm_provision(kubevirt_vm)
- Added assert for kubeconfig
- Unified storageclass to sapstorage for both trident and hpp and make configurable
- trident: make parameters configurable in role - Renamed default namespace for VMs to sap
- Define public ssh key explicitly - fixed network config cloudinit
- added sap_vm_provision_host_specification_plan to sample var file
- make disk access_modes configurable
- make CPU performance settings configurable
Deprecated vars