Skip to content

Conversation

santiagocasas
Copy link
Owner

@santiagocasas santiagocasas commented Dec 1, 2024

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@santiagocasas santiagocasas self-assigned this Dec 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.45701% with 178 lines in your changes missing coverage. Please review.

Project coverage is 34.98%. Comparing base (311699a) to head (0ba6a27).

Files with missing lines Patch % Lines
cosmicfishpie/analysis/fishconsumer.py 0.00% 122 Missing ⚠️
cosmicfishpie/utilities/legendre_tools.py 0.00% 30 Missing ⚠️
cosmicfishpie/LSSsurvey/spectro_cov.py 25.00% 15 Missing ⚠️
cosmicfishpie/configs/config.py 60.00% 6 Missing ⚠️
cosmicfishpie/LSSsurvey/spectro_obs.py 66.66% 2 Missing ⚠️
cosmicfishpie/cosmology/cosmology.py 83.33% 2 Missing ⚠️
cosmicfishpie/utilities/utils.py 92.30% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   35.70%   34.98%   -0.72%     
==========================================
  Files          29       30       +1     
  Lines        5406     5616     +210     
==========================================
+ Hits         1930     1965      +35     
- Misses       3476     3651     +175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@santiagocasas santiagocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@santiagocasas
Copy link
Owner Author

merging of all side branches

@santiagocasas santiagocasas merged commit c7af4ed into main Dec 1, 2024
10 checks passed
@santiagocasas santiagocasas deleted the merge_jelly branch September 30, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants