Skip to content

Conversation

santiagocasas
Copy link
Owner

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.43725% with 157 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e0197e7). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cosmicfishpie/configs/config.py 40.78% 45 Missing ⚠️
cosmicfishpie/LSSsurvey/spectro_cov.py 34.54% 36 Missing ⚠️
cosmicfishpie/cosmology/nuisance.py 21.05% 30 Missing ⚠️
cosmicfishpie/LSSsurvey/spectro_obs.py 38.63% 27 Missing ⚠️
cosmicfishpie/analysis/fishconsumer.py 0.00% 17 Missing ⚠️
cosmicfishpie/fishermatrix/cosmicfish.py 88.23% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage        ?   35.53%           
=======================================
  Files           ?       29           
  Lines           ?     5344           
  Branches        ?        0           
=======================================
  Hits            ?     1899           
  Misses          ?     3445           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santiagocasas santiagocasas self-assigned this Dec 1, 2024
Copy link
Owner Author

@santiagocasas santiagocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all sounds good to myself

@santiagocasas santiagocasas merged commit b487397 into main Dec 1, 2024
10 checks passed
@santiagocasas santiagocasas deleted the merge_surveys branch September 30, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants