Skip to content

Conversation

santiagocasas
Copy link
Owner

Closes #67

Changes proposed in this pull request:

  • symbolic class as a solver in cosmology and config.
  • new yaml files for symbolic
  • removing hard-coded neutrino parametrizations
  • improving feedback prints
  • complete docstring documentation of cosmology class
  • minor fixes in related classes

Before submitting

  • [ x] I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • [ x] I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • [ x] If this PR fixes a bug, I've added a test that will fail without my fix.
  • [x ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link
Collaborator

@Sefa76 Sefa76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work thank you! Just small optimizations and a fail save

Copy link
Owner Author

@santiagocasas santiagocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review ! I have committed changes so that this can be merged!

Copy link
Collaborator

@Sefa76 Sefa76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you!

@santiagocasas santiagocasas merged commit b22ae40 into main Sep 19, 2024
10 checks passed
@Sefa76 Sefa76 deleted the symbopk branch September 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Symbolic PofK as a boltzmann solver

2 participants