Skip to content

Conversation

santiagocasas
Copy link
Owner

@santiagocasas santiagocasas commented Sep 29, 2025

Closes likelihood module task

Changes proposed in this pull request:

  • likelihood module for photo
  • likelihood module for spectro

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@santiagocasas santiagocasas self-assigned this Sep 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 59.84252% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.79%. Comparing base (50ac673) to head (2f61613).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
cosmicfishpie/likelihood/spectro_like.py 20.89% 53 Missing ⚠️
cosmicfishpie/likelihood/photo_like.py 77.44% 30 Missing ⚠️
cosmicfishpie/likelihood/base.py 63.26% 18 Missing ⚠️
cosmicfishpie/analysis/fishconsumer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   34.95%   36.79%   +1.83%     
==========================================
  Files          30       34       +4     
  Lines        5627     5966     +339     
==========================================
+ Hits         1967     2195     +228     
- Misses       3660     3771     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@santiagocasas
Copy link
Owner Author

@Sefa76 would you be so kind to review this PR quite superficially? thanks!

Copy link
Collaborator

@Sefa76 Sefa76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i left a comment but that's more of a discussion. Can be merged as is

@santiagocasas santiagocasas merged commit 46085a4 into main Sep 30, 2025
11 checks passed
@santiagocasas santiagocasas deleted the likemodule branch September 30, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants