Upgrade to Django 4.2 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop using pytz and use zoneinfo - Small changes to storages configuration - USE_L10N is deprecated (default on) and will be always on starting with Django 5
davidfischer
commented
Jun 4, 2024
| @@ -40,7 +40,7 @@ COPY . /code/ | |||
| RUN --mount=type=cache,target=/root/.npm npm install | |||
| RUN npm run build | |||
|
|
|||
| RUN python manage.py collectstatic --noinput | |||
| RUN python manage.py collectstatic --noinput --clear | |||
There was a problem hiding this comment.
This is minor but fixes a warning when building the container locally. Since the static directory won't exist when GitHub Actions is building it for deployment, this only helps dev.
Jer-Pha
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
- All discussed changes from Upgrade to Django 4.2 #154 are addressed
- All third-party apps and middleware are compatible w/ Django 4.2
- All doc URLs are valid (manually checked)
- TZ changes look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.djangoproject.com/en/4.2/releases/4.2/
Fixes #154