Skip to content

feat: add database-driven organizer page #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

Jer-Pha
Copy link
Contributor

@Jer-Pha Jer-Pha commented May 28, 2024

Resolves #64

Organizers will need to be manually added to the database via /admin/. By default, these changes will only show active organizers and will link to their Meetup profile and LinkedIn (optional).

There are commented lines in views.py, __init__.py, and organizers.html that could display past organizers below active organizers. This would be a good way to honor those that have helped in the past. This would require more manual work adding extra people in /admin/ and changing their active status to False.

@Jer-Pha
Copy link
Contributor Author

Jer-Pha commented May 28, 2024

Hmm, not sure why it failed the check.

@davidfischer
Copy link
Member

Hmm, not sure why it failed the check.

There's two reasons if you clickthrough to the CI details (you can see those right?). Firstly, there was a minor code formatting issue that needs to be cleaned up with Black or with the pre-commit. However, the code has 100% test coverage and is set to fail if it drops below that. That means that if you add new code, the code needs to be executed by tests. You added a test for it, but there's a couple lines it didn't execute. Notably since no organizers were added in the test, none of those lines in the template were executed.

For now, I say we just keep the code to the active organizers. The main goal of the page is so that folks can contact an organizer if they have a question.

@davidfischer
Copy link
Member

Looks like we're working simultaneously. I created a branch (branched from this) that added a few things that were missing:

  • There was no database migration
  • I fixed up the tests/linting
  • I removed the inactive organizers code

@Jer-Pha
Copy link
Contributor Author

Jer-Pha commented May 30, 2024

Looks like we're working simultaneously. I created a branch (branched from this) that added a few things that were missing:

  • There was no database migration
  • I fixed up the tests/linting
  • I removed the inactive organizers code

I'll hold off on any other changes, sorry about that!

@davidfischer
Copy link
Member

davidfischer commented May 30, 2024

I'll hold off on any other changes, sorry about that!

Go ahead but you might start from or at least look at the other branch (we can merge it into this PR too). One thing to think about is should there be an image for organizers? Should it just be the image from meetup? How do we get that image?

Edit: some discussion of this topic here.

@Jer-Pha Jer-Pha closed this May 30, 2024
@Jer-Pha Jer-Pha deleted the organizers branch May 30, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an organizers page
2 participants