Skip to content

Update whitenoise to 6.5 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

davidfischer
Copy link
Member

There's an encoding issue that affects iOS/Safari and I'm hoping this change resolves it (see whitenoise docs).

There's an encoding issue that affects iOS/Safari
and I'm hoping this change resolves it.
Copy link
Contributor

@Jer-Pha Jer-Pha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. There is no need for the latest version of WhiteNoise (6.6.0) since that would require updating the project's Python version and the iOS/Safari issue was only for WhiteNoise < 5.0.

@davidfischer
Copy link
Member Author

At some point we do need to upgrade python. It should be painless but will take some verification.

@davidfischer davidfischer merged commit d0ce055 into main May 17, 2024
1 check failed
@davidfischer davidfischer deleted the davidfischer/whitenoise-update-6.5 branch May 17, 2024 01:15
@Jer-Pha
Copy link
Contributor

Jer-Pha commented May 17, 2024

I was looking into this but I don't have experience with Heroku, pre-commit, or tox.

It seems like these are the necessary changes, using python 3.12 as the example:

[tox.ini] envlist = py312,lint
[.pre-commit-config.yaml] language_version: python3.12
[runtime.txt] python-3.12.3
[ci.yml] python-version: "3.7"
[README.md] * Python 3.12+ (I actually don't know if this is necessary?)

I'm still new at all of this, so it might be naive to think changing 5 lines is enough.

@davidfischer
Copy link
Member Author

That is pretty much exactly what I would do. However I suspect there may be some incompatible dependencies. After trying that upgrade and updating your dependencies things may require some additional changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants