-
Notifications
You must be signed in to change notification settings - Fork 5
chore: Update security notice #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Best Practices Badge App suggests we should document what users can expect from our project in terms of security.
Reviewer's Guide by SourceryThis pull request updates the security notice to clarify the project's security posture, mentioning the use of No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
@GhostofGoes, care to review and approve? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 2 2
Lines 166 166
Branches 37 37
=======================================
Hits 156 156
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider whether a disclaimer is needed, stating that users should also adhere to
argparse
's security guidelines.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The Best Practices Badge App suggests we should document what users can expect from our project in terms of security.
Summary by Sourcery
Documentation:
argparse
and the use offlake8-bandit
for security scanning.