-
Notifications
You must be signed in to change notification settings - Fork 5
Support Python 3.13 #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #248
Conversation
Reviewer's Guide by SourceryThis PR adds Python 3.13 support by updating configuration files and documentation. The changes are straightforward, involving the addition of Python 3.13 to version matrices, classifiers, and badges. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jmgate - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Missing quote after Python 3.12 version string (link)
Overall Comments:
- There's a syntax error in continuous-integration.yml - missing closing quote after '3.12'
- Adding Python 3.13 support seems premature as it's still in alpha. Consider waiting for beta release and include actual compatibility testing before adding support.
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
506ad77
to
453fd05
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 2 2
Lines 166 166
Branches 37 37
=======================================
Hits 156 156
Misses 4 4
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Type: Task
Description
Update the project config, CI, and docs to support Python 3.13.
Related Issues/PRs
Closes #245.
Summary by Sourcery
Update project configuration, CI, and documentation to support Python 3.13.
CI:
Documentation: