Skip to content

Support Python 3.13 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Support Python 3.13 #248

merged 1 commit into from
Dec 17, 2024

Conversation

jmgate
Copy link
Collaborator

@jmgate jmgate commented Dec 17, 2024

Type: Task

Description

Update the project config, CI, and docs to support Python 3.13.

Related Issues/PRs

Closes #245.

Summary by Sourcery

Update project configuration, CI, and documentation to support Python 3.13.

CI:

  • Add Python 3.13 to the CI workflow matrix to ensure compatibility.

Documentation:

  • Update documentation to reflect support for Python 3.13.

@jmgate jmgate self-assigned this Dec 17, 2024
Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This PR adds Python 3.13 support by updating configuration files and documentation. The changes are straightforward, involving the addition of Python 3.13 to version matrices, classifiers, and badges.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Python 3.13 to CI workflow configuration
  • Added '3.13' to the Python version matrix for CI testing
.github/workflows/continuous-integration.yml
Updated project metadata and documentation to include Python 3.13
  • Added Python 3.13 to the Python version badge
  • Added Python 3.13 classifier to project metadata
README.md
pyproject.toml
doc/source/index.rst

Assessment against linked issues

Issue Objective Addressed Explanation
#245 Update CI configuration to support Python 3.13
#245 Update documentation to reflect Python 3.13 support

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jmgate - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Missing quote after Python 3.12 version string (link)

Overall Comments:

  • There's a syntax error in continuous-integration.yml - missing closing quote after '3.12'
  • Adding Python 3.13 support seems premature as it's still in alpha. Consider waiting for beta release and include actual compatibility testing before adding support.
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jmgate jmgate force-pushed the support-python-3.13 branch from 506ad77 to 453fd05 Compare December 17, 2024 17:25
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (e48e614) to head (453fd05).
Report is 51 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files           2        2           
  Lines         166      166           
  Branches       37       37           
=======================================
  Hits          156      156           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmgate jmgate merged commit b69354f into master Dec 17, 2024
14 checks passed
@jmgate jmgate deleted the support-python-3.13 branch December 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.13
1 participant