patch: Indicate that the package is typed #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to PEP 561, we need to add this file to static type checkers can infer the types from the package.
jmgate
added
the
Type: Task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
===========================================
+ Coverage 0 94.04% +94.04%
===========================================
Files 0 2 +2
Lines 0 168 +168
Branches 0 43 +43
===========================================
+ Hits 0 158 +158
- Misses 0 4 +4
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
william76
approved these changes
May 13, 2024
GhostofGoes
approved these changes
May 13, 2024
|
I can confirm that the 1.0.8 release made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Task
Description
According to PEP 561, we need to add this file to static type checkers can infer the types from the package.
Motivation
When working on open-sourcing staged-script, I noticed
mypywasn't pulling in type information from this package.